Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format config files more in line with the Laravel skeleton #1273

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Format config files more in line with the Laravel skeleton #1273

merged 1 commit into from
Sep 28, 2023

Conversation

adevade
Copy link
Contributor

@adevade adevade commented Sep 25, 2023

  • Empty line at the start and end of main array
  • Empty line between all top level keys
  • No leading backslash when referencing classes
  • Import "one-off" classes
  • Do not import classes part of an array list, like pipelines
  • Fix indentation on some comments
  • Add example classes with suggested namespace where no defaults exist
  • Change formatting of "in-array comments"

Nothing has been changed except formatting.
For reference: laravel/laravel config folder

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 0:03am

@alecritson
Copy link
Collaborator

Thanks @adevade did you use a auto formatter to do this or was it manual? My only thought is if we did this could it slip back to the old formatting unless we can pick it up in something like pint?

@adevade
Copy link
Contributor Author

adevade commented Sep 27, 2023

@alecritson Nope, unfortunately this was manual work. Don't know if there's a formatter available for this?

@alecritson
Copy link
Collaborator

Hmm yeah it doesn't look like there is anything and I can't see any actions Laravel have set up for it. We'll get this change in though thanks and hopefully keep an eye on it going forward.

@alecritson alecritson merged commit a226892 into lunarphp:0.6 Sep 28, 2023
alecritson pushed a commit that referenced this pull request Sep 29, 2023
# Conflicts:
#	packages/core/config/cart.php
@adevade adevade deleted the config-formatting branch October 2, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants