Add the ability to exclude brands, collections, products and variants from discounts #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e1bafcf.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Any thoughts on this one? |
|
@ryanmitchell Yeah looks good just want to give it a bit of a spin beforehand and confirm with @glennjacobs :) |
alecritson
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Thanks @ryanmitchell had a play around with this and it seems pretty useful, will get it ready for the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the 'limitations' area of discounts to also allow items to be excluded from the discount:
For example, this allows you to add a collection or brand, but exclude certain products from that brand.
Requires #1285 to be merged first