Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blank and null coupons #1293

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

ryanmitchell
Copy link
Contributor

If you enter a value in the coupon field, but then decide to blank it, it's no longer null, it's now blank, which means it wont automatically apply.

This PR fixes that behaviour.

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 9:04am

@alecritson alecritson merged commit 2a1c79a into lunarphp:0.6 Oct 6, 2023
12 checks passed
@ryanmitchell ryanmitchell deleted the fix/empty-coupon-code branch October 6, 2023 09:14
alecritson pushed a commit that referenced this pull request Oct 12, 2023
alecritson pushed a commit that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants