Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to lunar:install and lunar:hub:install to allow for non-prompting usage #1294

Closed
wants to merge 20 commits into from

Conversation

charlielangridge
Copy link
Contributor

This updates to the command lunar:install allows options to be used to:
--retainConfig - if a config already exists, this option retains the exisiting config without prompting
--migrate - this runs the database migrations without prompting
--firstName - this option allows the input of new admin user first name
--lastName - this option allows the input of new admin user last name
--email - this option allows the input of new admin user email name
--password - this option allows the input of new admin user password name

This updates to the command lunar:hub:install allows options to be used to:
--firstName - this option allows the input of new admin user first name
--lastName - this option allows the input of new admin user last name
--email - this option allows the input of new admin user email name
--password - this option allows the input of new admin user password name

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 7:29pm

@wychoong
Copy link
Contributor

wychoong commented Oct 6, 2023

is there use case that you can share for using this command programmatically?

@wychoong
Copy link
Contributor

wychoong commented Oct 6, 2023

@glennjacobs i think the pint action is not running the check as the dirty flag only look for uncommitted files, not changed files in PR, see aglipanci/laravel-pint-action#4 (comment)

@charlielangridge
Copy link
Contributor Author

@wychoong Our use case is that we have created a custom fresh setup command that migrates fresh, runs the installer and then imports a load of products - this allows us to rapidly deploy without having prompts (specifically having to type in the user details each time)

@charlielangridge
Copy link
Contributor Author

Another thing to add is the alternative in our use case would be to copy the install commands and make adjustments to our installations, but then if there's any updates to the install code in future, our custom install command obv wouldn't be correct

@glennjacobs
Copy link
Contributor

@glennjacobs i think the pint action is not running the check as the dirty flag only look for uncommitted files, not changed files in PR, see aglipanci/laravel-pint-action#4 (comment)

Oh, that's a bit silly. I'll look at changing that in a different PR.

@glennjacobs
Copy link
Contributor

@charlielangridge can you please target main as this isn't a bug fix.

@charlielangridge charlielangridge changed the base branch from 0.6 to main October 18, 2023 11:48
@charlielangridge
Copy link
Contributor Author

@glennjacobs - that's been done

@glennjacobs glennjacobs added the enhancement Improvement to existing functionality label Dec 18, 2023
@glennjacobs glennjacobs added this to the v0.8 milestone Dec 18, 2023
@glennjacobs
Copy link
Contributor

I am going to close this, as we're not looking to add new functionality to v0.8 now. However, we do want to incorporate this into v1.0 so I will be raising an issue to consider this at the point we review the installer commands.

@glennjacobs glennjacobs closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants