Fix taxbreakdown casting #1301
Closed
Fix taxbreakdown casting #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is great, we've tripped over this a few times so thank you. |
|
@alecritson I think we need to target |
glennjacobs
reviewed
Oct 12, 2023
…nar into fix/fix-taxbreakdown-casting # Conflicts: # packages/core/config/cart.php
|
Closing to move to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguably this is an API change, however as it stands I think Taxbreakdown casting is a bit broken.
The current problem is when we save the data to the database, it doesn't have the same structure as the
TaxBreakdownvalue object which it's meant to represent.The other problem is when populating the
tax_breakdowncolumn we just map what we think the casting object is expecting and it will JSON encode it after some mapping. I think this is fairly inconsistent and not obvious to developers what they should be doing, should they want to populate atax_breakdowncolumn manually. This PR would enable a developer to simply pass aTaxbreakdownvalue object to any database column which uses theTaxbreakdowncasting.Furthermore this PR looks to make the
Taxbreakdowncasting actually cast back in the value object it represents so it's consistent.