-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model extending #1661
Merged
Merged
Model extending #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/lunar into feature/model-extending
…/lunar into feature/model-extending
Co-authored-by: wychoong <[email protected]>
# Conflicts: # packages/core/src/Models/Currency.php
…nto feat/model-extending-ar
…nto feat/model-extending-ar
@alecritson going to need to fix the conflicts before this can be merged. |
…nto feat/model-extending-ar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks to build on the current work done for model extending and includes but not limited to the following changes:
morphMap
instead of having concrete classes in the database for polymorphic relationshipsnewFactory
method didn't like having the return type.addDir
guessContractClass
to take namespace into account as not all Lunar models (from addons) will have the same namespaceaddDirectory
method to prevent excessive calls toreplace
oradd
methods.modelClass()
App\Models\MyProduct
instead ofApp\Models\Product
it will still use the correct table name.observe
method on models that useHasModelExtending
to forward to the custom class even if observe is called on the Lunar model.Set as draft for the moment as there is a fair amount of changes so just want to double check before hitting the button.