Fixes customer group in Discounts

[yasirmturk]

Fixes #2045

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lunar-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 3, 2025 3:50pm

[alecritson]

Thanks @yasirmturk I think we should try to avoid nested if statements and elseif's

[yasirmturk]

I agree @alecritson , what do you suggest? conditional or null colescing statement?

[alecritson]

I agree @alecritson , what do you suggest? conditional or null colescing statement?

I kind of think that we should always consider the customer's groups, regardless, so maybe something like this:

if ($cart && $customerGroups = $cart->customer?->customerGroups) {
    $this->customerGroup($customerGroups);
}

if ($this->customerGroups->isEmpty() && $defaultGroup = CustomerGroup::getDefault()) {
    $this->customerGroup($defaultGroup);
}

What do you think?