Release epub#108
Open
rick1026 wants to merge 3 commits into
Open
Conversation
Extend the release workflow to build separate EPUB artifacts for en, vi, and zh in parallel via a matrix job, then publish all built files under a single GitHub Release. Using fail-fast: false so a failure in one language does not block releasing the others. Also refactor build_epub.py to drive language-specific paths, filenames, and titles from a mapping, and add zh support (title/subtitle + choice).
…pty-dist guard - Wire language-specific subtitle through EPUBConfig.subtitle field so create_cover_image renders the correct cover text per --lang instead of always using the hardcoded English defaults - Add continue-on-error for zh matrix leg (zh/ content not yet populated) and explicit permissions: contents: read on the build job - Add 'Check artifacts exist' guard step before Create Release so an all-languages-fail scenario produces a clear failure rather than confusing softprops errors; make 'List built artifacts' tolerant of an empty dist/
…h module constant Language metadata (subdir, filename, title, subtitle) was stored as EPUBConfig instance fields and then accessed as class-level attributes in lang_map — a fragile pattern that silently breaks if any field loses its default. Move this data to a module-level _LANG_METADATA dict and remove the now-redundant vi_/en_/zh_ title/subtitle fields from EPUBConfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief summary of what this PR does.
Type of Change
Related Issues
Closes #(issue number)
Changes Made
What to Review
What should reviewers focus on?
Files Changed
path/to/file1.mdpath/to/file2.mdTesting
How have you tested this?
Checklist
Screenshots or Examples
If applicable, show what this adds:
Breaking Changes
Does this change any existing content or behavior?
If yes, please describe:
Additional Notes
Any other information for reviewers?