chore: use SymbolRef as the Lang map key#1195
Open
arthurpaulino wants to merge 1 commit intomainfrom
Open
Conversation
arthurpaulino
force-pushed
the
ap/interned-symbols
branch
from
63ee1a9 to
c0c7bec
Compare
arthurpaulino
commented
Mar 5, 2024
Comment on lines
-321
to
-324
| // TODO: should `Lang` hold `Arc<Symbol>` instead? | ||
| lang.add_coprocessor((*new_sym).clone(), NewCoprocessor::default()); | ||
| lang.add_coprocessor((*lookup_sym).clone(), LookupCoprocessor::default()); | ||
| lang.add_coprocessor((*insert_sym).clone(), InsertCoprocessor::default()); |
Contributor
Author
There was a problem hiding this comment.
This is less cumbersome now
arthurpaulino
force-pushed
the
ap/interned-symbols
branch
from
c0c7bec to
dd7c1eb
Compare
arthurpaulino
force-pushed
the
ap/interned-symbols
branch
from
dd7c1eb to
2114a95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
Langand adapt the rest of the codebaseCloses #1191