-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements #72
base: master
Are you sure you want to change the base?
Conversation
I added some uses of C++11 that are breaking Travis. Can it be changed to pass |
This post goes into some detail about the benefits/motivations of each patch: https://www.microsoft.com/en-us/research/blog/optimizing-barnes-hut-t-sne/ |
Thanks for submitting this and writing up your findings! I think switching Travis to For the vantage-tree point implementation, I have been meaning to switch to an approach based on product quantization for quite some time now, but I haven't had time to work on that yet. I will do some local testing, and merge presuming the maps produced by the code still look as expected. |
Sounds great, thanks! I eyeballed the results on my test datasets before and after this series, and the differences were only in the least-significant couple of digits. I imagine they only differ at all due to the change in how I'm computing the centers of mass. If anything the new way should be slightly more accurate as it's not accumulating errors on every |
No description provided.