trayicon: workarounds for AppIndicator issues #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t available Signed-off-by: Yuri Konotopov <[email protected]>
See-Also: mate-desktop/mate-desktop#589 Signed-off-by: Yuri Konotopov <[email protected]>
Signed-off-by: Yuri Konotopov <[email protected]>
|
Works good on Ubuntu GNOME |
|
For simplicity I think one plugin is better. I consider the modernisation of the code very important and especially the improved visibility of the counter is worth any incompatibilities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be noted that for some DEs with StatusNotifier support (eg Mate [1]) the look of attention icon will change and can not be reverted. However it will be consistent between X11 and Wayland sessions. I think this is ok and look and feel enhancement requests should be filled for such DEs if needed.
We can split off AppIndicator support into separate plugin instead of this workarounds however code needs to be duplicated between 2 plugins.
[1] The look of attention icon in Mate
