Fix background color with GTK3 #75
Conversation
|
I also noticed this issue, though it only happens when you have a single tab open. Edit: I can confirm that this indeed fixes the color of that background. Btw another difference (not caused by your PR) I noticed in the GTK 3 version is that it doesn't have lines around the toolbar like the GTK 2 version has. |
| @@ -1878,6 +1878,16 @@ exo_icon_view_expose_event (GtkWidget *widget, | |||
|
|
|||
| if (!gtk_cairo_should_draw_window (cr, priv->bin_window)) | |||
| return FALSE; | |||
|
|
|||
| /* draw a background according to the css theme */ | |||
| style = gtk_widget_get_style_context (widget); | |||
There was a problem hiding this comment.
I suppose it should be not retrieved again at line 1993 with this addition, right?
There was a problem hiding this comment.
Correct, I just tried and it works the same. PR updated
| #if GTK_CHECK_VERSION(3, 0, 0) | ||
| style = gtk_widget_get_style_context (widget); | ||
| #else | ||
| #if !GTK_CHECK_VERSION(3, 0, 0) |
There was a problem hiding this comment.
This line should be moved above if to not leave it alone.
There was a problem hiding this comment.
You're right. I should look twice before committing. Fixed
The background color of the icon view is wrong. When only one tab is open, it is the same color as the toolbars.
ib
force-pushed
the
fix-gtk3-background
branch
from
75d3986 to
fe9f46c
Compare
|
@livanh, are you okay with the merge and the resulting commit? |
|
Thank you very much for your contribution. |
I tried building for gtk3, and the background color was wrong (it was the same as the toolbars - see attached picture, left side). This is how I fixed it (result on right side). I can make changes if required for merging.