Add clientcreatorpool abstraction for utilizing multiple github apps for extra ratelimit #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smonero
changed the title
server/neptune/temporalworker/clientcreatorpool/clientcreatorpool.go
Outdated
Show resolved
Hide resolved
miguelmolina95
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will put the doc explaining things in slack. Basically this is adding functionality to be able to choose which gh app has the biggest remaining rate limit, which is updated in the crons. Note there could potentially be race conditions since this is all in-memory and we have 2 separate temporal workers, however that should be a non-issue as there should always be enough rate limit to go around, and even if there isn't it, it would come back shortly after being exhausted.