Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: initialize timeFormat preference #2821

Merged
merged 2 commits into from
Oct 19, 2023
Merged

frontend: initialize timeFormat preference #2821

merged 2 commits into from
Oct 19, 2023

Conversation

jecr
Copy link
Contributor

@jecr jecr commented Oct 19, 2023 •
edited
Loading

The timeZone preference was not being initialized, as default preferences were initialized as{}. This caused some undefined issues when trying to access it, this PR initializes the preferences object with the timeFormat set at UTC

Testing Performed

manual

@jecr jecr requested a review from a team as a code owner October 19, 2023 19:20
@jecr jecr merged commit 73b0296 into main Oct 19, 2023
5 checks passed
@jecr jecr deleted the initialize-timezone-pref branch October 19, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdslaugh jdslaugh jdslaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jecr @jdslaugh