Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Adding Vertical Orientation to Stepper and adjusting Wizard to account for it #2932

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

jdslaugh
Copy link
Contributor

@jdslaugh jdslaugh commented Feb 12, 2024

Description

  • Adjusts the Stepper to allow the orientation prop to be passed in
  • Adjusts the Wizard to handle passing in the orientation prop down to the stepper
  • Styling changes to both to update to latest and account for new positioning
  • Updates to stories
  • Added package to hopefully alleviate issue found during build:
Creating an optimized production build...
One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.
babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

Screenshots

Wizard (Before)

Screenshot 2024-02-12 at 11 02 51 AM

Storybook (Before)

Screenshot 2024-02-12 at 11 03 22 AM

Wizard (After)

Horizontal

Screenshot 2024-02-05 at 1 22 54 PM

Vertical

Screenshot 2024-02-05 at 1 23 02 PM

Storybook (After)

Horizontal

Screenshot 2024-02-05 at 2 05 33 PM

Vertical

Screenshot 2024-02-05 at 2 05 40 PM

Testing Performed

manual

@jdslaugh jdslaugh requested a review from a team as a code owner February 12, 2024 19:04
@jdslaugh jdslaugh merged commit 97de041 into main Feb 13, 2024
8 checks passed
@jdslaugh jdslaugh deleted the vertical-stepper branch February 13, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants