Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Refactor workflows to use new layout #3159

Merged
merged 17 commits into from
Nov 6, 2024

Conversation

septum
Copy link
Contributor

@septum septum commented Oct 29, 2024

Description

  • Modified the configuration and component of all routes of every workflow to use the new layout

Screenshots

Standard Layout

Before

clutch lyft net_catalog_ (1)

After

localhost_3000_catalog_testbuildnotify

Note

New props were added to the layout to display only the breadcrumbs and preserve previous route component header

Wizard Layout

Before

clutch lyft net_dash_ (1)

After

localhost_3000_catalog

No Layout

Before

clutch lyft net_dash_

After

localhost_3000_dash

Testing Performed

Manual

@septum septum requested a review from a team as a code owner October 29, 2024 19:24
frontend/packages/core/src/WorkflowLayout/index.tsx Outdated Show resolved Hide resolved
frontend/packages/core/src/WorkflowLayout/index.tsx Outdated Show resolved Hide resolved
frontend/packages/core/src/WorkflowLayout/index.tsx Outdated Show resolved Hide resolved
frontend/packages/wizard/src/wizard.tsx Outdated Show resolved Hide resolved
frontend/workflows/audit/src/index.tsx Outdated Show resolved Hide resolved
@jdslaugh
Copy link
Contributor

@septum looking at this:

localhost_3000_catalog_testbuildnotify

Curious why Catalog is black and the project name is blue. Would think it was the other way around since the route looks to be on the project versus the main catalog

@septum
Copy link
Contributor Author

septum commented Oct 31, 2024

@septum looking at this:

localhost_3000_catalog_testbuildnotify

Curious why Catalog is black and the project name is blue. Would think it was the other way around since the route looks to be on the project versus the main catalog

This is because the comment above:

There's an issue with the list of workflow paths available:

  • When rendering the workflow paths not all possible routes are not available to this check, because some workflows are fragmented between instances but not reconciled into one single workflow.

Basically, when rendering this path, the /catalog/ root path is not available, because it's in another instance of clutch. I added another check to manually add the /${route.path}, but it was providing some root paths that did not have a component.

Copy link
Contributor

@jecr jecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice having JSDocs or something akin to give users some guidance on using the new feature

@septum septum merged commit bbd04de into main Nov 6, 2024
8 checks passed
@septum septum deleted the workflow-layout-refactoring branch November 6, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants