Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Refactor workflows to use new spacing units #3160

Merged
merged 25 commits into from
Nov 6, 2024

Conversation

septum
Copy link
Contributor

@septum septum commented Oct 29, 2024

Description

  • Modified the styling props and config for every workflow to use the new spacing units

Screenshots

Standard
Before

localhost_3000_catalog_ (1)

After

localhost_3000_catalog_

Wizard
Before

localhost_3000_ec2_instance_terminate

After

localhost_3000_catalog_ (2)

No Layout
Before

localhost_3000_k8s_job-logs

After

localhost_3000_k8s_job-logs

Testing Performed

Manual

@septum septum requested a review from a team as a code owner October 29, 2024 19:31
Copy link
Contributor

@jdslaugh jdslaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you provide a few before/after screenshots (doesn't have to be everything) just so there's a reference.

frontend/workflows/k8s/src/k8s-dash-search.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@jecr jecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

Base automatically changed from workflow-layout-refactoring to main November 6, 2024 01:29
@septum septum merged commit 2a2f4fe into main Nov 6, 2024
8 checks passed
@septum septum deleted the workflow-spacing-refactoring branch November 6, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants