Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress configuration 'ingressAnnotations' and 'ingressTLSSecretName' #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Smana
Copy link

@Smana Smana commented Mar 21, 2020

In order to be able to configure the ingresses this PR allows to set annotations and the TLS secret name to retrieve the certificates.

fixes #131

@Smana
Copy link
Author

Smana commented Mar 21, 2020

By the way, I've updated the CRD manually but there may be a way to automatically generate it. Please let me know

@vDMG
Copy link

vDMG commented Jun 19, 2020

@anandswaminathan or someone can take a look at this PR plz ?

@kumare3
Copy link

kumare3 commented Jun 21, 2020

I will work with one of them and take a look. Sorry if this has gone stale. I think people just missed it

@schmichri
Copy link

Bump as it would be really handy to set ingress annotations.

@maccamlc
Copy link

Oh, I was looking at #230

Think ingressClassName also needed now, and I would definitely appreciate this capability :)

@mootezbessifi
Copy link

why until now, this PR was not accepted and merged??
It is very important to manage annotations in ingress in terms of Auth and ssl configs !!

@mootezbessifi
Copy link

@mwylde @glaksh100 @kumare3 @anandswaminathan could you support here please

@bagipriyank
Copy link

new version of nginx seems to need annnotation kubernetes.io/ingress.class: nginx on the ingress. would really appreciate if we can resolve the merge conflicts here, and merge and release this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure ingress class
7 participants