Node

[Arri98]

Upated Node to latest LTS. Made minor changes to the ErizoAPI and updated mock-require because compatibility issues.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

[davidguv]

@Arri98
Several messages appear during execution

DeprecationWarning: Invalid 'main' field in '/opt/licode/erizo_controller/node_modules/node-getopt/package.json' of './lib'. Please either fix that or report it to the module author

jiangmiao/node-getopt#20

[xmartinez]

This node update also updates npm:

npm --version
8.5.0

which uses a new package-lock.json file format[1] (introduced in npm v7).

[1] https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json#lockfileversion

Currently, the file is converted on every build and test execution:

npm install
(...)
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile

We should do the conversion once, and commit the format change as part of this PR. This will also reduce the noise on future dependency update PRs.

The file format can be converted using:

run npm install --package-lock-only --ignore-scripts --no-audit --no-fund

for all JS projects:

find . -name package-lock.json | sort
./erizoAPI/package-lock.json
./erizo_controller/package-lock.json
./extras/basic_example/package-lock.json
./node_modules/babel-code-frame/package-lock.json
./nuve/package-lock.json
./package-lock.json
./spine/package-lock.json
./test/package-lock.json

@Arri98 Could you update the PR with these changes, please?

[xmartinez]

@Arri98 Looking good :-) Just a couple of nits, and the package-lock.json update (I think that it makes sense to address the file format change in this PR).

[xmartinez]

We should also update package-lock.json, which can be done by running:

npm install --package-lock-only --ignore-scripts --no-audit --no-fund

(This will also update the file format, as mentioned in my previous comment).

[xmartinez]

Nit: Can we remove this whitespace-only change? (It adds some noise to the PR).

[xmartinez]

Nit: Can we remove this whitespace-only change? (It adds some noise to the PR).

[xmartinez]

@Arri98 @lodoyun We have been testing this change (applied to pre-v10.13) for a while.

We have performed a load test using a single stream with upto 1200 subscribers:

The load tests ran reliably. Also the CPU utilization of the ErizoJS of this PR (test_id=13) is very similar to the pre-v10.13 one (test_id=12):

The latter was expected, as the node version upgrade should only affect the control plane (the data plane is handled by the C++ implementation).

We have also been dogfooding the PR change using the new version in our internal meetings (also without a glitch).

[Arri98]

Updated lockfiles and removed the whitespaces in the erizo_controlle file

[lodoyun]

This looks good to me. Thanks! 👍