Ignore DATA and HEADERS frames received after stream reset - #9697
Open
iVamsi wants to merge 4 commits into
Open
Conversation
Track recently reset stream IDs in a bounded set so late in-flight frames on canceled or reset streams are discarded instead of triggering an erroneous RST_STREAM with PROTOCOL_ERROR. Leftover DATA bytes still count toward connection-level flow control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When OkHttp canceled or reset a stream, in-flight DATA frames arriving shortly after would find no active stream and trigger a redundant
RST_STREAMwithPROTOCOL_ERROR.RFC 9113 requires discarding those late frames after sending
RST_STREAM, while still counting DATA toward the connection flow-control window.This change remembers recently reset stream IDs in a bounded set (256) and drops late
DATAandHEADERSon those streams instead of sending another RST. Discarded DATA still updates connection flow control. DATA on idle or naturally finished streams is stillPROTOCOL_ERROR.This also resolves the flakiness in
discardedDataFramesAreCounted.Fixes #6171
Fixes #9672