Don't reuse a connection when a redirect changes scheme - #9739
Open
iVamsi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a request starts over http and the server redirects to https on the same host and port, OkHttp reused the first connection. That socket was still unencrypted. The app still saw an https URL, with no TLS handshake and no certificate check.
The reuse check on that same call only compared host and port. Moving from http to https did not count as a new destination. The connection pool already treats those as different, because one is configured for TLS and the other is not.
That check now requires the same scheme as well. Redirects from port 80 to 443 are unchanged. Those ports already differ.