fix(anthropic): harden structured JSON parsing - #5
Open
lzhs1995 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens Anthropic structured JSON output handling by making fenced JSON extraction more robust (LF/CRLF, unlabeled fences, case-insensitive json), introducing a dedicated error kind for empty structured output, and adding privacy-preserving diagnostics that avoid logging raw response content.
Changes:
- Broaden accepted whole-response JSON fences (unlabeled and
jsonlabel, case-insensitive; LF/CRLF supported) while still failing closed on prose, unsupported labels, malformed fences, or trailing content. - Split “empty structured output” into a distinct
kiro_structured_empty_outputerror kind. - Add warn-level structured diagnostics (lengths, fence classification, first non-whitespace classification, per-process salted digest, optional parse position) without logging raw content, plus tests for the new parsing rules.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kiro_structured_empty_outputValidation
structured_json_is_strict_and_canonical: 1 passed, 0 failedgit diff --check: passDeployment boundary
Train A only. This PR does not enable Gate B flags, change RPM, modify credentials/proxies, or authorize shadow/canary/enforce. Any new kiro.rs digest invalidates the prior R2 evidence and requires a fresh R2 anchor.