Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2 claimant proposals #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add 2 claimant proposals #24

wants to merge 2 commits into from

Conversation

toninorair
Copy link
Collaborator

@toninorair toninorair commented Oct 9, 2024 •
edited
Loading

Claimants proposals for current epoch

@toninorair toninorair marked this pull request as ready for review October 10, 2024 15:47
PierrickGT
PierrickGT reviewed Oct 10, 2024
View reviewed changes
foundry.toml
Comment on lines -18 to -20
block_number = 19_818_700
block_timestamp = 1_715_091_047
fork_block_number = 19_818_700
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be kept to not break the integration tests.

deluca-mike
deluca-mike approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@deluca-mike deluca-mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the script is correct, we should get into the habit of creating cleaner, more standardized, and more testable scripts, with accompanying tests, in this case, for the proposal creations and for the resulting key-velue sets having the desired effects at the Wrapper.

@toninorair
Copy link
Collaborator Author

While the script is correct, we should get into the habit of creating cleaner, more standardized, and more testable scripts, with accompanying tests, in this case, for the proposal creations and for the resulting key-velue sets having the desired effects at the Wrapper.

@deluca-mike that is something I would like to propose you do every voting epoch given that it is directly related to the wrapper project. All great and necessary points!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierrickGT PierrickGT PierrickGT approved these changes

@deluca-mike deluca-mike deluca-mike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toninorair @PierrickGT @deluca-mike