Skip to content

Commit

Permalink
Update src/library/basetrackcache.cpp
Browse files Browse the repository at this point in the history 
Co-authored-by: Owen Williams <[email protected]>
  • Loading branch information
@m0dB @ywwg
m0dB and ywwg authored Dec 11, 2024
1 parent 74b6185 commit 0ffec8a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/library/basetrackcache.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ void BaseTrackCache::getTrackValueForColumn(TrackPointer pTrack,
} else if (fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_KEY) == column) {
trackValue.setValue(pTrack->getKeyText());
QVariant keyCodeValue(static_cast<int>(pTrack->getKey()));
trackValue = KeyUtils::keyFromColumns(std::move(trackValue), std::move(keyCodeValue));
trackValue = KeyUtils::keyFromColumns(trackValue, keyCodeValue);

Check failure on line 385 in src/library/basetrackcache.cpp

View workflow job for this annotation

GitHub Actions / clazy 

rvalue reference to type 'QVariant' cannot bind to lvalue of type 'QVariant'

Check failure on line 385 in src/library/basetrackcache.cpp

View workflow job for this annotation

GitHub Actions / Ubuntu 22.04 

cannot bind rvalue reference of type ‘QVariant&&’ to lvalue of type ‘QVariant’

Check failure on line 385 in src/library/basetrackcache.cpp

View workflow job for this annotation

GitHub Actions / macOS 13 x64 

rvalue reference to type 'QVariant' cannot bind to lvalue of type 'QVariant'

Check failure on line 385 in src/library/basetrackcache.cpp

View workflow job for this annotation

GitHub Actions / clang-tidy 

rvalue reference to type 'QVariant' cannot bind to lvalue of type 'QVariant' [clang-diagnostic-error]

Check failure on line 385 in src/library/basetrackcache.cpp

View workflow job for this annotation

GitHub Actions / coverage 

cannot bind rvalue reference of type ‘QVariant&&’ to lvalue of type ‘QVariant’

Check failure on line 385 in src/library/basetrackcache.cpp

View workflow job for this annotation

GitHub Actions / macOS 13 arm64 

rvalue reference to type 'QVariant' cannot bind to lvalue of type 'QVariant'

Check failure on line 385 in src/library/basetrackcache.cpp

View workflow job for this annotation

GitHub Actions / Windows 2019 (MSVC) 

'QVariant KeyUtils::keyFromColumns(QVariant &&,QVariant &&)': cannot convert argument 1 from 'QVariant' to 'QVariant &&'
} else if (fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_KEY_ID) == column) {
trackValue.setValue(static_cast<int>(pTrack->getKey()));
} else if (fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_BPM_LOCK) == column) {
Expand Down

0 comments on commit 0ffec8a

Please sign in to comment.