avoid rendering on images with 0 or negative width or height

Author: m0dB

src/waveform/renderers/allshader/digitsrenderer.cpp

@@ -69,6 +69,10 @@ float allshader::DigitsRenderer::height() const {
 
 void allshader::DigitsRenderer::updateTexture(
         float fontPointSize, float maxHeight, float devicePixelRatio) {
+    if (std::lround(maxHeight * devicePixelRatio) <= 0) {
+        return;
+    }
+
     if (fontPointSize == m_fontPointSize && maxHeight == m_maxHeight) {
         return;
     }

src/waveform/renderers/allshader/waveformrendermark.cpp

@@ -403,9 +403,14 @@ void allshader::WaveformRenderMark::updatePlayPosMarkTexture() {
     imgwidth = 11.f;
     imgheight = height;
 
-    QImage image(static_cast<int>(imgwidth * devicePixelRatio),
-            static_cast<int>(imgheight * devicePixelRatio),
-            QImage::Format_ARGB32_Premultiplied);
+    const QSize size{static_cast<int>(std::lround(imgwidth * devicePixelRatio)),
+            static_cast<int>(std::lround(imgheight * devicePixelRatio))};
+
+    if (size.width() <= 0 || size.height() <= 0) {
+        return;
+    }
+
+    QImage image(size, QImage::Format_ARGB32_Premultiplied);
     image.setDevicePixelRatio(devicePixelRatio);
     image.fill(QColor(0, 0, 0, 0).rgba());
 

src/waveform/renderers/waveformmark.cpp

@@ -311,8 +311,8 @@ struct MarkerGeometry {
         }
     }
     QSize getImageSize(float devicePixelRatio) const {
-        return QSize{static_cast<int>(m_imageSize.width() * devicePixelRatio),
-                static_cast<int>(m_imageSize.height() * devicePixelRatio)};
+        return QSize{static_cast<int>(std::lround(m_imageSize.width() * devicePixelRatio)),
+                static_cast<int>(std::lround(m_imageSize.height() * devicePixelRatio))};
     }
 };
 
@@ -357,9 +357,14 @@ QImage WaveformMark::generateImage(float devicePixelRatio) {
 
     m_label.setAreaRect(markerGeometry.m_labelRect);
 
+    const QSize size{markerGeometry.getImageSize(devicePixelRatio)};
+
+    if (size.width() <= 0 || size.height() <= 0) {
+        return QImage{};
+    }
+
     // Create the image
-    QImage image{markerGeometry.getImageSize(devicePixelRatio),
-            QImage::Format_ARGB32_Premultiplied};
+    QImage image{size, QImage::Format_ARGB32_Premultiplied};
     image.setDevicePixelRatio(devicePixelRatio);
 
     // Fill with transparent pixels