Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generate_shaders_gl): Replace new union expression with old syntax #19

Conversation

Holzhaus
Copy link

This makes it compatible with Python 3.9 (default on macOS).

This makes it compatible with Python 3.9 (default on macOS).
@m0dB
Copy link
Owner

m0dB commented Dec 22, 2024

Thanks for taking care of this. It is unfortunate that macOS comes with such on old python but using the non-system default has the tendency to result in a mess, so adapting your script to 3.9 is much appreciated.

@m0dB m0dB merged commit 2bab73c into m0dB:rg-use-opengl-node-and-add-shaders Dec 22, 2024
10 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12454903912

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 31.758%

Files with Coverage Reduction New Missed Lines %
src/engine/enginevumeter.cpp 1 97.44%
Totals Coverage Status
Change from base Build 12453948639: -0.001%
Covered Lines: 33335
Relevant Lines: 104965

💛 - Coveralls

@Holzhaus Holzhaus deleted the rg-use-opengl-node-and-add-shaders-python branch December 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants