Skip to content

Conversation

@m293wang
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Resolve conflicting merges

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@github-actions
Copy link

Autograder results

question status comment
1 data directory does not exist
2 rawdata not moved to data/raw
3
4 Missing directories: data/processed/server_logs, data/processed/user_logs, data/processed/event_logs
5 No server log files in data/raw
6 No user log files in data/raw; No event log files in data/raw
7
8 data/inventory.txt does not exist
9

@github-actions
Copy link

Autograder results

question status
1
2
3
4
5
6
7
8
9

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question 2: No need for 'mkdir' command. Simply use the 'mv' command to rename rawdata to raw. That way you won't have to do
'mv raw/rawdata/* raw #adding this line here ...'
at line no. 40.

Question 5: 'cd' command has been used to change directories. It’s generally not advisable to use the cd command in a shell script. Maintaining the same current working directory before and after the script is considered a good practice.

Everything else looks good!

m293wang added a commit that referenced this pull request Nov 28, 2024
Implemented suggested changes by TA
@github-actions
Copy link

Autograder results

question status comment
1
2 rawdata not moved to data/raw
3
4
5 No server log files in data/raw
6 No user log files in data/raw; No event log files in data/raw
7
8
9

Update line 2 to exclude "/*"
@github-actions
Copy link

Autograder results

question status
1
2
3
4
5
6
7
8
9

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates. Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants