New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Exclude bug #23

Open

dkniffin wants to merge 1 commit into m4i:master from dkniffin:bug/excluded-cop-files-not-excluded

Contributor

dkniffin commented Aug 18, 2016

Before, if you did something like:

Documentation:
  Exclude:
    - 'subdir/**/*.rb'

It wouldn't actually exclude that. It was because rubocop looks for those exclusions using an absolute path for the file name.


          Fix a bug where using Exclude for a cop in the config file wasn't res…

a60f3f1

…pected

Contributor Author

dkniffin commented Aug 18, 2016

I'll look into this more, but it has to do with the filename being wrong in the git show commands in lib/rubocop/git/commit.rb, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet