This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Minor fix for problems experienced on Samsung Galaxy S3 mini #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some devices WheelView has been unresponsive and very hard to use. The problem has been identified on Samsung S3 Mini - the wheel was unresponsive unless you have pressed wheel for a while and start scrolling after that. The problem was also reproducable on Samsung S3 but only if user scrolled the wheel very very fast… After connecting both phones to ADB and quick investigation of LogCat I have found out that MotionEvent.ACTION_MOVE has never been processed by WheelView. The reason was that MotionEvent.ACTION_CANCELED has been received immediately after MotionEvent.ACTION_DOWN. So I updated onTouchEvent method to call getParent().requestDisallowInterceptTouchEvent(true) immediately after ACTION_DOWN event has been detected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some devices WheelView has been unresponsive and very hard to use. The problem has been identified on Samsung S3 Mini - the wheel was unresponsive unless you have pressed wheel for a while and start scrolling after that.
The problem was also reproducable on Samsung S3 but only if user scrolled the wheel very very fast…
After connecting both phones to ADB and quick investigation of LogCat I have found out that MotionEvent.ACTION_MOVE has never been processed by WheelView. The reason was that MotionEvent.ACTION_CANCELED has been received immediately after MotionEvent.ACTION_DOWN. So I updated onTouchEvent method to call getParent().requestDisallowInterceptTouchEvent(true) immediately after ACTION_DOWN event has been detected.