Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homework submission #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Homework submission #13

wants to merge 3 commits into from

Conversation

Ghoffm
Copy link

@Ghoffm Ghoffm commented Sep 18, 2024

Forgot we needed to create a pull request until you mentioned it in class, sorry!

@pcantrell
Copy link
Contributor

Good work!

For the final step of this assignment:

  1. Open up the “Files changed” tab of this pull request.
  2. Open up my own solution to the homework so that you can compare the two (perhaps in a separate browser tab or window): https://github.com/mac-comp381/wordy/compare/solution

Walk through the two solutions, comparing one small chunk of code at a time. Things to think about as you go:

  • What differences do you notice? What similarities?
  • Sometimes one way is clearly better than another. Sometimes there are tradeoffs. Sometimes two ways are both perfectly fine, and it’s just a matter of taste. If you notice a difference, it doesn’t mean your way is wrong! It just means there are multiple approaches. Notice the difference between “oh, wow, Paul’s way / my way is clearly better” versus “Yup, that’s fine too.”
  • Some of my solution uses Java language features we never cover in 127 and 128. What differences are because of those features, versus taking a different approach with building blocks you already knew about?
  • Are there lots of differences in your code that aren’t there at all in mine? Are they because of (1) debug output left in your code, (2) commented-out or dead code you didn’t fully delete, or (3) reformatting that had nothing to do with the task at hand? When you’re on a team, it’s best to avoid committing any of those three things.

Now, to complete the assignment:

Write a brief note about one or two things that stood out to you as you compare the two solutions.

You can ask a question, or just name something notable. Post these comments here in this comment thread and/or as comments on individual lines of your code in the “Files changed” tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants