Skip to content

Commit

Permalink
chore: Apply comments from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
Marçal Albert Castellví committed Oct 7, 2024
1 parent c7ceab7 commit 4c782bf
Showing 1 changed file with 9 additions and 16 deletions.
25 changes: 9 additions & 16 deletions .github/workflows/coverage-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
if: ${{ !github.event.pull_request.draft }} && ${{ github.base_ref == 'refs/heads/main' }}
if: !github.event.pull_request.draft && github.base_ref == 'refs/heads/main'
steps:
- name: Check if PR is created by Dependabot
id: dependabot-check
Expand All @@ -42,46 +42,39 @@ jobs:
fi
- name: Check if the workflow should run
if: ${{ steps.dependabot-check.outputs.is_dependabot == 'false' }} && ${{ github.base_ref == 'refs/heads/main' }}
if: steps.dependabot-check.outputs.is_dependabot == 'false' && github.base_ref == 'refs/heads/main'
run: echo "The workflow is allowed to run for this PR"

- name: 🧲 Checkout
if: ${{ steps.dependabot-check.outputs.is_dependabot == 'false' }} && ${{ github.base_ref == 'refs/heads/main' }}
if: steps.dependabot-check.outputs.is_dependabot == 'false' && github.base_ref == 'refs/heads/main'
uses: actions/checkout@v4

- name: 🛠️ Setup Node.js with Cache
if: ${{ steps.dependabot-check.outputs.is_dependabot == 'false' }} && ${{ github.base_ref == 'refs/heads/main' }}
if: steps.dependabot-check.outputs.is_dependabot == 'false' && github.base_ref == 'refs/heads/main'
uses: actions/setup-node@v4
with:
node-version: "20.x"
cache: "yarn"

- name: 📦 Install dependencies
if: ${{ steps.dependabot-check.outputs.is_dependabot == 'false' }} && ${{ github.base_ref == 'refs/heads/main' }}
if: steps.dependabot-check.outputs.is_dependabot == 'false' && github.base_ref == 'refs/heads/main'
run: yarn install

- name: 🔥 Run tests and collect coverage
if: ${{ steps.dependabot-check.outputs.is_dependabot == 'false' }} && ${{ github.base_ref == 'refs/heads/main' }}
if: steps.dependabot-check.outputs.is_dependabot == 'false' && github.base_ref == 'refs/heads/main'
run: yarn test

- name: Setup Pages
if: ${{ steps.dependabot-check.outputs.is_dependabot == 'false' }} && ${{ github.base_ref == 'refs/heads/main' }}
if: steps.dependabot-check.outputs.is_dependabot == 'false' && github.base_ref == 'refs/heads/main'
uses: actions/configure-pages@v5

- name: Upload artifact
if: ${{ steps.dependabot-check.outputs.is_dependabot == 'false' }} && ${{ github.base_ref == 'refs/heads/main' }}
if: steps.dependabot-check.outputs.is_dependabot == 'false' && github.base_ref == 'refs/heads/main'
uses: actions/upload-pages-artifact@v3
with:
path: "./coverage"

- name: Deploy to GitHub Pages
if: ${{ steps.dependabot-check.outputs.is_dependabot == 'false' }} && ${{ github.base_ref == 'refs/heads/main' }}
if: steps.dependabot-check.outputs.is_dependabot == 'false' && github.base_ref == 'refs/heads/main'
id: deployment
uses: actions/deploy-pages@v4

- name: Publish Results Badge
uses: wjervis7/[email protected]
if: success() || failure()
with:
result-type: lines
upload-badge: ${{ github.base_ref == 'refs/heads/main' }}

0 comments on commit 4c782bf

Please sign in to comment.