Resource manager custom resampler #988
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Since it's been a while and since it's a relatively small diff, I thought to bump this pr and ask for any updates encase it fell through the cracks, we need to manually patch to update our miniaudio currently. Please forgive me if I am at all out of place for posting this reminder here, I don't mean to be a bother! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi David,
Here's one more small contribution for your consideration.
This adds support for a custom resampler to the resource manager. Not for pitch shifting / doppler as discussed in #965, but rather for initial decoding of sounds.
Please let me know if there's anything I need to change or improve. Just like with the previous PR, please be advised that I may need a little patience / support with regards to stylistic concerns due to a disability.
Kind regards,
Jordan.