Skip to content

bloaty: fix the port, revbump #25284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

barracuda156
Copy link
Contributor

Description

  1. Current portfile ignores that the source prefers external libs. This is not seen on buildbots, since bundled duplicates will be built in absence of external ones. But we do not want this.
  2. Set required C++ standard.
  3. Fix for < 10.7.
  4. Use commit-based build until next release, since 2020 release fails to link against current re2 etc., which use C++17, not C++11.
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@barracuda156 barracuda156 marked this pull request as draft August 11, 2024 16:34
@barracuda156
Copy link
Contributor Author

Well, no idea what fails with clang specifically, but opened an issue with upstream: google/bloaty#381

@barracuda156
Copy link
Contributor Author

No responce from upstream, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants