Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issues #10

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Fixing issues #10

merged 5 commits into from
Jan 27, 2025

Conversation

adkoele
Copy link
Contributor

@adkoele adkoele commented Jan 27, 2025

There were some requirements for the JOSS, I removed some unused code, and I fixed some issues that popped up during the tutorial with Uni Innsbruck early January

@adkoele adkoele requested a review from tvdbogert January 27, 2025 14:32
tvdbogert
tvdbogert approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@tvdbogert tvdbogert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see the apparel code removed, makes things more clear.
I did not do the unit tests, but ran IntroductionExamples.script2D and IMUTracking2D.scriptIMU2D. Both still run correctly.

@adkoele adkoele merged commit ac7054b into main Jan 27, 2025
1 check passed
@adkoele adkoele deleted the Fixing_Issues branch January 27, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdbogert tvdbogert tvdbogert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adkoele @tvdbogert