Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change groups to always return a tuple of strings #85

Merged
merged 32 commits into from
Sep 7, 2023
Merged

Change groups to always return a tuple of strings #85

merged 32 commits into from
Sep 7, 2023

Conversation

livhe
Copy link
Collaborator

@livhe livhe commented Aug 3, 2023

Fixes #78

@livhe livhe marked this pull request as draft August 3, 2023 12:17
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #85 (deda5a4) into main (75b958e) will decrease coverage by 0.26%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   90.48%   90.23%   -0.26%     
==========================================
  Files          23       23              
  Lines        1882     1894      +12     
==========================================
+ Hits         1703     1709       +6     
- Misses        179      185       +6
Files Changed Coverage Δ
tpcp/validate/_scorer.py 95.03% <ø> (ø)
tpcp/_dataset.py 92.57% <75.00%> (-3.14%) ⬇️
tpcp/_utils/_score.py 97.32% <100.00%> (ø)
tpcp/optimize/optuna.py 90.11% <100.00%> (ø)

AKuederle
AKuederle reviewed Aug 3, 2023
View reviewed changes
tpcp/_dataset.py Outdated Show resolved Hide resolved
@livhe livhe marked this pull request as ready for review August 4, 2023 12:33
AKuederle
AKuederle reviewed Aug 5, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated

### Changed

- **BREAKING CHANGE**: The `group` property of the `Dataset` class is now called `group_label` and always returns named
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split this into two points? So the rename and the function change

CHANGELOG.md Outdated Show resolved Hide resolved
docs/guides/algorithm_validation_tpcp.rst Outdated Show resolved Hide resolved
tests/test_dataset.py Outdated Show resolved Hide resolved
tests/test_dataset.py Outdated Show resolved Hide resolved
tpcp/_dataset.py Show resolved Hide resolved
tpcp/_dataset.py Show resolved Hide resolved
tpcp/_dataset.py Outdated Show resolved Hide resolved
AKuederle
AKuederle reviewed Aug 7, 2023
View reviewed changes
_tasks.py Outdated Show resolved Hide resolved
@livhe livhe marked this pull request as draft August 7, 2023 15:41
livhe and others added 22 commits September 7, 2023 15:31
@livhe
Change groups to always return a tuple of strings and modify tests ac…
a8670c0 
…cordingly
@livhe
add groups related documentation and change group Tuple name
bfe8b34
@livhe
rename create_group_labels
7ba0e7e
@livhe
rename group
088cb11
@livhe
rename groups
0395c1e
@livhe
fix docs conf
3fcc011
@livhe
add group(s) properties with deprecation warning
ebeab1e
@livhe
update changelog
26ebf15
@livhe
reformat
f79ce19
@livhe
add datapoint_label(s) properties and tests
162da59
@livhe
reformat
1f03301
@livhe
refine dataset docs
f72b163
@livhe
fix mistake in algo validation guide
988e8fc
@livhe
revise changelog
952c9fd
@livhe
rename test functions to fit the new property names
44c85ae
@livhe
fix datapoint_label error test
00cf3e5
@livhe
add tests for datapoint_labels and group_labels
6448651
@livhe
add comment to groupby docstring
cd6c169
@AKuederle @livhe
Update CHANGELOG.md
e00e77c
@livhe
fix accidental rename
5ca6639
@livhe
add tests for (assert_)is_singe_datapoint
98755bf
@livhe
typos in changelog
70ab0bd
@livhe livhe marked this pull request as ready for review September 7, 2023 14:31
AKuederle
AKuederle approved these changes Sep 7, 2023
View reviewed changes
examples/datasets/_01_datasets_basics.py Outdated Show resolved Hide resolved
examples/datasets/_01_datasets_basics.py Outdated Show resolved Hide resolved
@AKuederle AKuederle merged commit 1f2d6ba into main Sep 7, 2023
@AKuederle AKuederle deleted the group_as_tuple branch September 7, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AKuederle AKuederle AKuederle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single Column datasets should also return a tuple as group
3 participants
@livhe @codecov-commenter @AKuederle