Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

86 get subset kwargs do not work if column name has spaces #96

Merged

Conversation

a-mosquito
Copy link
Collaborator

No description provided.

@a-mosquito a-mosquito linked an issue Oct 4, 2023 that may be closed by this pull request
@a-mosquito a-mosquito requested a review from AKuederle October 4, 2023 14:15
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #96 (c290153) into main (589a1bc) will increase coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   90.11%   90.14%   +0.03%     
==========================================
  Files          23       23              
  Lines        1902     1908       +6     
==========================================
+ Hits         1714     1720       +6     
  Misses        188      188              
Files Coverage Δ
tpcp/_dataset.py 92.73% <100.00%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

tpcp/_dataset.py Show resolved Hide resolved
tpcp/_dataset.py Outdated Show resolved Hide resolved
tests/test_dataset.py Outdated Show resolved Hide resolved
tpcp/_dataset.py Outdated Show resolved Hide resolved
@AKuederle AKuederle merged commit 0d91732 into main Oct 5, 2023
4 checks passed
@AKuederle AKuederle deleted the 86-get_subset-kwargs-do-not-work-if-column-name-has-spaces branch October 5, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_subset kwargs do not work if column name has spaces
3 participants