Add support for forms and controllers + event listeners#23
Open
rabauss wants to merge 17 commits intomadeyourday:develop-v3from
Open
Add support for forms and controllers + event listeners#23rabauss wants to merge 17 commits intomadeyourday:develop-v3from
rabauss wants to merge 17 commits intomadeyourday:develop-v3from
Conversation
rabauss
commented
Feb 8, 2023
rabauss
commented
Feb 8, 2023
rabauss
commented
Feb 8, 2023
rabauss
commented
Feb 8, 2023
Contributor
Author
|
@ausi what about this PR? |
ausi
reviewed
May 9, 2023
ausi
reviewed
May 9, 2023
ausi
reviewed
May 9, 2023
rabauss
force-pushed
the
feature/form-columns
branch
from
1e3e1e1 to
6ed97c0
Compare
Contributor
Author
|
I refactored some suggestions from the review - hopefully I did not miss anything. |
rabauss
commented
May 10, 2023
rabauss
force-pushed
the
feature/form-columns
branch
from
078ef54 to
c833c39
Compare
Contributor
Author
|
@ausi Any suggestions to merge this PR? |
Member
|
Looks ready to merge on a first glance, will try to find some time, sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First I just wanted to add support for forms (see #4).
While implementing this PR got bigger and bigger - maybe we could also split some parts
This PR is based on the v3-branch which also introduces some more breakpoints (#19).
In summary I did the following big changes