Add back tools/CommonRandomNumbers.h #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y - this is still needed by epochX/sycl (and by epoch1/2) This reverts parts of MRs madgraph5#663 and madgraph5#664 - it is related to madgraph5#613 Revert "removed superfluous copy of CommonRandomNumbers.h from tools directory. now lies in CODEGEN directory, is included in process generation" This reverts commit c7136a3.
valassi
changed the title
|
self merging |
This was referenced May 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zeniheisser (cc @roiser) I am adding back tools/CommonRandomNumbers.h as discussed - this is still needed by epochX/sycl (and by epoch1/2). In other words, the sycl builds would now break.
In any case I would keep it there (for epoch1/2) also later, unless we remove epoch1/2. It's clutter, but does not really harm.
This reverts parts of MRs #663 and #664 - it is related to #613