pubsub krm #36
pubsub krm #36
Conversation
| @@ -15,7 +15,8 @@ COPY cmd/${FUNCTION}/*.go . | |||
| RUN --mount=type=cache,target=/root/.cache/go-build go build -mod readonly -v -o /usr/local/bin/config-function ./ | |||
|
|
|||
| RUN controller-gen crd paths=./pkg/workloads output:crd:dir=crd/workloads && \ | |||
There was a problem hiding this comment.
shouldn't need to hardcode individual directories, make a make directive to do this, so that it can work both within and outside of the container.
| @@ -16,6 +16,7 @@ build: check-function-var | |||
| crd: check-function-var | |||
| controller-gen crd paths=./pkg/workloads output:crd:dir=crd/workloads | |||
| controller-gen crd paths=./pkg/pgbouncer output:crd:dir=crd/pgbouncer | |||
| controller-gen crd paths=./pkg/pubsub output:crd:dir=crd/pubsub | |||
There was a problem hiding this comment.
oh, this exists. we shouldn't have to hardcode, and we should be able to call this from within the dockerfile. If we have different implementations for the same thing, it is error prone and confusing.
| @@ -0,0 +1,35 @@ | |||
| package main | |||
There was a problem hiding this comment.
let's start figuring out how we can generate these.
| ) | ||
|
|
||
| // +kubebuilder:object:root=true | ||
| type PubsubSubscription struct { |
There was a problem hiding this comment.
there's some krm function type that we have to eventually use
pkg/pubsub/pubsubsubscription.go
Outdated
| Config PubSubConfig `json:"config,omitempty"` | ||
| } | ||
|
|
||
| func (pubSubConfig *PubSubConfig) fill_defaults() { |
There was a problem hiding this comment.
- use camelcase
- don't call it this, this is basically a 'constructor', so they should be called something like 'NewSubscription' if it is returning a reference to a initialised subscription object.
pkg/common/fnutils/gcp_project.go
Outdated
| @@ -0,0 +1,14 @@ | |||
| package fnutils | |||
There was a problem hiding this comment.
not in the fnutil path because it doesn't have anything to do with krm. Maybe we'll rename fnutils to krm or something.
There was a problem hiding this comment.
you can just put this in common
https://bukukas.atlassian.net/browse/BPI-996