Improve robustness of gz_open by adding a null check for the 'mode' parameter #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your excellent work on this library.
This PR proposes a change to improve the robustness of the
gz_openfunction by adding aNULLcheck for the mode parameter.This ensures its argument validation is consistent with the existing check for the
pathparameter. More importantly, it prevents a potential segmentation fault if the function is called with a NULL mode, making it safer and more predictable for users.I hope you find this a welcome improvement. Thank you for your time and for considering this contribution.