Expression Support (PR #215 rebased onto main) - #275
Closed
sshin23 wants to merge 3 commits into
Closed
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…string quotes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- ext/ExaModelsKernelAbstractions.jl: update all kernel calls from AdjointNodeSource(x)/SecondAdjointNodeSource(x) to the two-argument form AdjointNodeSource(x, nothing)/SecondAdjointNodeSource(x, nothing) now required after PR #215 added the offset_exps field - src/nlp.jl: add missing `pars = gen.iter` in add_con! (3-arg form) before the call to _add_con!, fixing UndefVarError at line 1199 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Please run: julia --project=@runic -e 'using Pkg; Pkg.add("Runic")'
julia --project=@runic -e "using Runic; exit(Runic.main(ARGS))" -- --fix <files>(or Note: the full diff is omitted because it can exceed GitHub Actions input limits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@add_expr/add_expr/subexprfor pre-computed subexpressions cached across AD evaluationssubexpr_test.jl, missingpars = gen.iterinadd_con!, andAdjointNodeSource/SecondAdjointNodeSourcesingle-arg calls updated to two-arg formTest plan
🤖 Generated with Claude Code