Fixes #258: Support colon indexing in function calls in generators - #289
Open
jsphchoi wants to merge 1 commit into
Open
Fixes #258: Support colon indexing in function calls in generators#289jsphchoi wants to merge 1 commit into
jsphchoi wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
===========================================
- Coverage 80.80% 55.86% -24.94%
===========================================
Files 20 25 +5
Lines 2021 4015 +1994
===========================================
+ Hits 1633 2243 +610
- Misses 388 1772 +1384 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Benchmark Results |
Fixes madsuite-org#258. `x[:, i]` expands each colon axis to the tuple of its entries, column-major as in Base, so it can be splatted (`f(z[:, i, k]...)`) or passed whole (`g(z[:, i, k])`) inside a generator. `x[:]` linearizes. Previously Variable and Parameter threw `MethodError: -(::Colon, ::Int64)` and Expression silently treated `:` as a symbolic index. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jsphchoi
force-pushed
the
jc/colon-indexing
branch
from
August 25, 2026 17:11
688490f to
52cd3f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #258
z[:,i,k]previously returnsMethodError: -(::Colon, ::Int64). Colon:now expands to a tuple of the entries along that dimension, so it can be splatted (f(z[:,i,k]...)) or passed whole (g(z[:,i,k])) when used as function inputs in a generator