An axis is measured by its length, whatever iterates it - #314
Merged
Conversation
The data-axis fix added _length(::AbstractArray); steering immediately supplied the next iterator type — zip(2:4, angles), its boundary conditions — as the same swallowed status 2 in a compiled library's layout query. Enumerating iterator types is the losing game, so the rule is now general: a number is the count itself, a symbolic node defers, and every other axis answers length. Swept against all seventeen COPS models: every block of every model resolves. Gates: ExaModels 1623/0/2 broken (grew by the zip regression test), ExaModelsCompiler 252/252. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Please run: julia --project=@runic -e 'using Pkg; Pkg.add("Runic")'
julia --project=@runic -e "using Runic; exit(Runic.main(ARGS))" -- --fix <files>(or Note: the full diff is omitted because it can exceed GitHub Actions input limits. |
Contributor
Benchmark Results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First fix of the release-candidate iteration (per the PR-per-fix loop).
COPS field testing supplied two iterator types in sequence: catmix's collocation table (fixed by
_length(::AbstractArray)in #313) and then steering'szip(2:4, angles)boundary conditions — the same failure shape, a MethodError swallowed into a status-2 layout query that leaves the model unconstructable through the consumer while compiling clean. Enumerating iterator types is the losing game, so this generalizes the rule: a number is the count itself, a symbolic node defers, every other axis answerslength.Verified by sweeping all seventeen COPS models (each built with its own
_argsdefaults): every block of every model resolves to integer dims. Regression test covers the zip axis beside the data axis. Gates: ExaModels 1623 / 0 failed / 2 broken, ExaModelsCompiler 252/252.Unblocks:
steering(the last of Nabla's original six), and COPS's full 35-model verification round.🤖 Generated with Claude Code