Pin ExaModels to main now that the recipe work has landed - #2
Merged
Conversation
`ss/refactor` was the branch carrying model recipes and ExaModelsC. It merged as madsuite-org/ExaModels.jl#294, so the pin now names a branch that exists only until someone deletes it, and that has stopped moving either way. Content-neutral today: `main` and the `ss/refactor` tip differ in one docs file and nothing under `src/`.
`test_the_classification_has_no_stale_entries` went red on this branch, and the pin change is not the cause: `LegacyExaCore`, `variable`, `parameter`, `constraint!` and `subexpr` were removed upstream in madsuite-org/ExaModels.jl#295 together with deprecated.jl, and they are absent from `ss/refactor` as well as from `main`. The green run that preceded this one installed `ss/refactor` at 97440a38, before #295 was merged into it; that ref has since lost them too, so reverting the pin would leave the suite just as red. The stale names are taken from the assertion's own output rather than from a grep, since `names(ExaModels)` is what the test compares against.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/examodels/juliapkg.jsonpinnedExaModelstoss/refactor. That branch carried model recipes and ExaModelsC, and it merged as madsuite-org/ExaModels.jl#294 — so the pin names a branch that has stopped moving and exists only until someone deletes it.Content-neutral today.
mainand thess/refactortip (3f8476b9) differ in exactly one file,docs/src/opf.jl; nothing undersrc/orExaModelsC/differs at all. So this changes which ref is followed, not which code is fetched.Two related things this PR does not touch
ss/recipecarries the same"rev": "ss/refactor"pin and needs the same change. Left to whoever owns that branch.rune/tapepins the SHAb9a8da0c, which is reachable from neithermainnorss/refactor— it was presumably rebased away. That pin is already dangling and won't be fixed by anything here.