Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Client functions to get transactions at an address / payment credential... #48

Merged
merged 19 commits into from
Apr 9, 2024
Merged

Feat: Client functions to get transactions at an address / payment credential... #48

merged 19 commits into from
Apr 9, 2024

Conversation

sourabhxyz
Copy link
Contributor

@sourabhxyz sourabhxyz commented Feb 12, 2024 •
edited
Loading

This PR adds,

  • GET /addresses/:address/transactions
  • asset query parameter to GET /addresses/cred/:credential/utxos
  • POST /addresses/cred/utxos
  • GET /addresses/cred/:credential/transactions
  • GET /assets/:asset
  • from, to, limit query parameters to GET /markets/dexs/ohlc/:dex/:pair
  • provision to prevent api-key from being leaked in error messages
  • provision to handle Maestro error bodies which are not enclosed in double quotes. Earlier behaviour was to expect message such as "Failed to deserialise" and not Failed to deserialise.
  • FromHttpApiData, ToHttpApiData instance for SlotNo
  • Eq, Ord, Enum, Bounded, ToJSON, FromHttpApiData instance for Order
  • Enum, Bounded, FromHttpApiData instance for Dex
  • Data, Typeable, Enum, Bounded, FromHttpApiData instance for Resolution and also refactored it's Show instance.

@sourabhxyz sourabhxyz marked this pull request as ready for review April 9, 2024 13:41
@sourabhxyz sourabhxyz requested a review from a team as a code owner April 9, 2024 13:41
@sourabhxyz sourabhxyz changed the title Feat: Client functions to get transactions at an address / payment credential Feat: Client functions to get transactions at an address / payment credential... Apr 9, 2024
Vardominator
Vardominator approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@Vardominator Vardominator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

@Vardominator Vardominator merged commit 609515b into main Apr 9, 2024
2 checks passed
@Vardominator Vardominator deleted the txAtAddressOrCredential branch April 9, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vardominator Vardominator Vardominator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sourabhxyz @Vardominator