Skip to content
This repository has been archived by the owner on Feb 21, 2020. It is now read-only.

Allow installation from OS packages #88

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

robinbowes
Copy link

These changes all started as I wanted to install sonar from OS packages (RPMs on EL7, specifically).

In simple terms, I've added a parameter use_packages which is false by default. If set true, the module will install sonarqube from an OS package. If false, it will use your code to install from source.

I've also updated the test configuration to work on later versions of puppet + ruby, and use rspec-puppet-facts.

I'm submitting this as a PR not because it's ready to accept, but so you get some visibility and can offer feedback :)

Individual commit messages:

  • Refactor to allow install from OS package
  • Use "version" parameter rather than separate package_version
  • Make user creation optional
  • Symlink sonar.sh into /etc/init.d
  • Enable embeddedDatabase port paramter in config (service won't start without it)
  • Revert "Symlink sonar.sh into /etc/init.d"
  • Add systemd service file
  • Notify service if install changes
  • Notify the daemon-reload exec
  • Don't remove the init script installed by the RPM
  • Only install systemd unit file on systems that use systemd
  • Open firewall ports, if requested
  • Add safe_yaml gem to make this work with puppet 3.x on ruby >= 2.2
  • Bump stdlib version
  • Fix duplicate declaration, and cleanup for puppet lint
  • update to more recent test helpers - fixes a lot of warnings
  • Update spec_helper and use rspec-puppet-facts

Use "version" parameter rather than separate package_version
Make user creation optional
Symlink sonar.sh into /etc/init.d
Enable embeddedDatabase port paramter in config (service won't start without it)
Revert "Symlink sonar.sh into /etc/init.d"
Add systemd service file
Notify service if install changes
Notify the daemon-reload exec
Don't remove the init script installed by the RPM
Only install systemd unit file on systems that use systemd
Open firewall ports, if requested
Add safe_yaml gem to make this work with puppet 3.x on ruby >= 2.2
Bump stdlib version
Fix duplicate declaration, and cleanup for puppet lint
update to more recent test helpers - fixes a lot of warnings
Update spec_helper and use rspec-puppet-facts
Also, bump minimum puppet requirement to latest 3.x release (3.8.7)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant