fix: inversion of var $title and $anchorText#362
Closed
Amadeco wants to merge 1 commit intomagefan:masterfrom
Closed
fix: inversion of var $title and $anchorText#362Amadeco wants to merge 1 commit intomagefan:masterfrom
Amadeco wants to merge 1 commit intomagefan:masterfrom
Conversation
This mistyping lead to display post title instead of anchor text defined in configuration's widget.
Owner
|
Thank you, @mageho , for your contribution. Unfortunately, we cannot merge this change as it will break the content of the existing users. We can fix this issue by just changing the labels in the widget settings https://prnt.sc/ztzm6b will this be OK? |
Contributor
Author
|
by swapping terms, it would be very confusing for developpers in the future, no ? Another approach will be to create a phtml template (Magento coding standard advice to exterrnalise html from code). Previous users from this widget can swape variable themself. |
Amadeco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mistyping lead to display post title instead of anchor text defined in configuration's widget.