Feature: Set card editions as favorite (for deck importing purposes) #14070
Conversation
JayDi85
left a comment
JayDi85
left a comment
There was a problem hiding this comment.
Need logic change. Also don’t forget about PR detail descriptions (screenshots, related issues refs, what you done, what left todo, are you planning to improve that, etc).
| MageFrame.getDesktop().setCursor(new Cursor(Cursor.WAIT_CURSOR)); | ||
| try { | ||
| DeckImporter importer = DeckImporter.getDeckImporter(file.getPath()); | ||
| importer.setPreferences(MageFrame.getPreferences()); |
There was a problem hiding this comment.
Must change the logic: import original cards, press right click to add/remove/apply favorite sets/cards versions. Do not modify import code with hidden features.
There was a problem hiding this comment.
Do not modify import code with hidden features.
Could you clarify this? If this is about passing preferences as a field to the importer, I could not figure out a way to add favorite logic to the import process without doing that.
There was a problem hiding this comment.
Import feature must import original cards and do not modify it by hidden logic without user notification/interaction.
Deck editor has full access to deck and cards data, so you can modify it from a deck editor, no needs in import code. Look for code example in oldVersionDeck method.
There was a problem hiding this comment.
UX logic for a user:
- open/import/construct original deck;
- press special button/menu like “Replace all cards by favorite versions”;
- check and save final result;
| } | ||
|
|
||
| private void markAsFavorite() { | ||
| Collection<CardView> toFave = dragCardList(); |
There was a problem hiding this comment.
Must have menu to add single card to favorite or whole set to favorite.
|
|
||
| void duplicateCards(Collection<CardView> cards); | ||
|
|
||
| void markCardsAsFavorite(Collection<CardView> cards); |
There was a problem hiding this comment.
Must be renamed to FavoriteImage here and other places, there are plans to add favorite cards list with fast access to it from deck editor. It’s not same as favorite images.
| } | ||
|
|
||
| public static void setFavoriteCard(String cardName, String cardNumber, String setCode) { | ||
| prefs().put(prefixedKey(KEY_FAVORITE_CARD_PREFIX, cardName), setCode + "##" + cardNumber); |
There was a problem hiding this comment.
I don’t like to use a java prefs to store user defined data. There are popular bugs with settings/data lost, e.g. after system java update. Current logic with subfolder and one record per card is fine anyway.
p.s. Images folder with additional text files can be more useful in the future like favorite_image_sets.txt and favorite_image_cards.txt And it will allow easy review and edit for a users.
2 participants
TODO: