WIP - Implement Waterbend mechanic #14105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
just need to write some tests, should be good |
Jmlundeen
reviewed
Dec 4, 2025
| // As an additional cost to cast this spell, waterbend {X}. | ||
| this.getSpellAbility().addCost(new WaterbendCost("{X}")); | ||
| this.getSpellAbility().addCost(new WaterbendXCost()); | ||
| this.addAbility(new SimpleStaticAbility( |
Contributor
There was a problem hiding this comment.
I can't currently test this, but I think this would already be handled by AbiliitesImpl.getRules unless I'm mistaken.
Contributor
Author
There was a problem hiding this comment.
it's a mana cost so it gets excluded and I don't think it's worth figuring out how to make it work rather than just having a workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to make the X version work but I wanted to open this and see if anyone had any thoughts on the regular version. I've tested it and it works.