Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map custom attribute groups #889

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

schnere
Copy link

@schnere schnere commented Feb 16, 2022

Description

This PR adds the custom attribute groups to mapProductA [FFP2-Vorlage.pdf](https://github.com/magento/data-migration-tool/files/8079329/FFP2-Vorlage.pdf) ttributeGroupNamesSourceDest Mapping array so that the attributes in the group get also added to the correct group on the destination system.
Furthermore the sorting is updated so that the custom attributes are sorted after the default attributes. Therefore 200 is added to the sorting value. I used this value because it is also used in getCustomAttributeSortOrder for attributes.

Fixed Issues (if relevant)

  1. Custom product attribute groups empty when migrating from 1.9.2.2 to 2.4.3 #888: Custom product attribute groups empty when migrating from 1.9.2.2 to 2.4.3

Manual testing scenarios

  1. Starting with Magento 1.9.2.2 having an attribute set with custom attribute groups with attributes assigned
  2. Migrate data to Magento 2.4.3
  3. The custom attribute group have now attributes assigned again

@schnere schnere closed this Feb 16, 2022
@schnere schnere reopened this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant